Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKv2 Test Map type in Diff #2787

Closed
VenelinMartinov opened this issue Dec 24, 2024 · 0 comments · Fixed by #2830
Closed

SDKv2 Test Map type in Diff #2787

VenelinMartinov opened this issue Dec 24, 2024 · 0 comments · Fixed by #2830
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Dec 24, 2024 •
edited
Loading

For schemas with a property with Map type we should test:

the following schema variations:

  • Optional
  • Required
  • Optional + Computed
    • set in the program
    • set by the provider
  • Defaults

we should additionally test each of these with:

  • ForceNew

for the following scenarios:

  • empty unchanged
  • non-empty unchanged
  • added
  • removed
  • changed key
  • changed value
@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Dec 24, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 24, 2024
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Dec 24, 2024
@VenelinMartinov VenelinMartinov self-assigned this Jan 14, 2025
@VenelinMartinov VenelinMartinov mentioned this issue Jan 14, 2025
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SDKv2 Diff tests for Map pulumi/pulumi-terraform-bridge
2 participants
@VenelinMartinov @pulumi-bot