This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
(maint) C++ Style Cleanup #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore a formatting argument, and update messages for a typo fix.
When passing arguments to a constructor that will be stored directly into the object, pass by value. This allows move semantics while not incurring any overhead if we need to create a copy (the copy will be created on constructor invocation rather than in the constructor). This requires that the argument is then std::moved into the object storage. In most other cases, preserve pass-by-reference. See https://github.com/puppetlabs/cppbestpractices/blob/master/03-FAQ.md#q-arguments-and-return-types-in-class-methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(maint) Default to pass constructor arguments by value
(maint) Fix minor issues from i18n work