Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r10k puppetfile install does not adhere to global exclude_spec false #1392

Open
vicinus opened this issue May 24, 2024 · 6 comments
Open

r10k puppetfile install does not adhere to global exclude_spec false #1392

vicinus opened this issue May 24, 2024 · 6 comments
Labels

Comments

@vicinus
Copy link

vicinus commented May 24, 2024

Describe the Bug

r10k puppetfile install removes the spec directories of the modules even if in the r10k.yaml configuration file is globally set, that the spec directories should not be removed:

deploy:
  exclude_spec: false

It works if in the Puppetfile for every module exclude_spec: false is set.

Expected Behavior

r10k puppetfile install should not remove the spec directories if in the r10k.yaml configuration file is globally set, that the spec directories should not be removed.

Steps to Reproduce

  1. Setup a Puppetfile with a module, that has a spec directory:
mod 'puppetlabs/apache',
  :git => 'https://github.com/puppetlabs/puppetlabs-apache.git',
  :ref => 'v12.1.0'
  1. Setup a r10k.yaml file which disabled spec directory removal:
deploy:
  exclude_spec: false
  1. Run r10k puppetfile install --config=r10k.yaml

Environment

r10k version 4.1.0

@vicinus vicinus added the bug label May 24, 2024
Copy link

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 24, 2024
@vicinus
Copy link
Author

vicinus commented Jul 24, 2024

...

@github-actions github-actions bot removed the stale label Jul 25, 2024
Copy link

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 23, 2024
@vicinus
Copy link
Author

vicinus commented Sep 23, 2024

...

@github-actions github-actions bot removed the stale label Sep 24, 2024
Copy link

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 23, 2024
@vicinus
Copy link
Author

vicinus commented Nov 25, 2024

...

@github-actions github-actions bot removed the stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant