From 7abfb97ab5a44d25977f0c3d352fade6ba8cdcb2 Mon Sep 17 00:00:00 2001 From: "kirby@puppetlabs.com" Date: Wed, 17 Jul 2019 14:24:44 -0700 Subject: [PATCH] (POOLER-140) Fix typo in domain This commit updates the reference to domain from vmpooler config. Without this change the domain value is read as an empty string and breaks checkouts. --- CHANGELOG.md | 3 +++ lib/vmpooler/api/v1.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ce7613de..98e60c8ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,9 @@ If you're looking for changes from before this, refer to the project's git logs & PR history. # [Unreleased](https://github.com/puppetlabs/vmpooler/compare/0.6.1...master) +### Added +- Validate a machine responds to vm\_ready? at checkout (POOLER-140) + # [0.6.1](https://github.com/puppetlabs/vmpooler/compare/0.6.0...0.6.1) ### Added diff --git a/lib/vmpooler/api/v1.rb b/lib/vmpooler/api/v1.rb index accf5cca8..3b3a98d1f 100644 --- a/lib/vmpooler/api/v1.rb +++ b/lib/vmpooler/api/v1.rb @@ -71,7 +71,7 @@ def fetch_single_vm(template) vms = backend.smembers("vmpooler__ready__#{template_backend}") next if vms.empty? vms.reverse.each do |vm| - ready = vm_ready?(vm, config[:domain]) + ready = vm_ready?(vm, config['domain']) if ready backend.smove("vmpooler__ready__#{template_backend}", "vmpooler__running__#{template_backend}", vm) return [vm, template_backend, template]