-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pure-help-block #32
Conversation
Thanks, this is helpful. I'll pull this down and test it locally. |
@dannytatom This looks good. I'm pulling it in, but I changed |
Looks better to me, I went with -block only because the other is -inline. |
I think we can assume
|
Looks good to me, thanks for the rundown. 😀 |
@dannytatom Thanks dude. Would you mind signing this CLA so that I can merge this in? We need a signed CLA to merge stuff in. I'm going to add this to the README.md. |
@tilomitra Signed! And no problem, hopefully I can get around to working a bit more on it, huge fan so far. |
@tilomitra |
@ericf So |
Remove "help" it's meaningless. Pure's whole goal is to "help" :P |
I think it makes sense to be there, as it's used (at least inline is) to give a tip about the form element it's next to or under. |
So again, my vote on naming is here: #32 (comment) |
I agree with @dannytatom that If "help" is an issue, we can change it to "message":
|
Ah, okay, I wasn't understanding "help" I thought it meant, help-make-forms-inline. I see now that it's for help text directed at the person using the form :) I think "message" is better and clearer that it has nothing to do with CSS, but rather helping layout a part of form, the text to help the user fill out the form. |
So are we cool with |
@tilomitra I am. Be sure to update the HISTORY.md with a |
@dannytatom Thanks dude. Merged and closed. |
Is it possible to provide an example on how to use these classes? |
@freshface You can find many examples on the project's website at http://purecss.io |
I noticed there's already a pure-help-inline, so I went ahead and added a block version. Might be useful to have them in the docs as well, I use them quite a bit when using Bootstrap.