Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate supported python versions #105

Closed
py-mine-bot opened this issue Feb 15, 2022 · 0 comments
Closed

Re-evaluate supported python versions #105

py-mine-bot opened this issue Feb 15, 2022 · 0 comments
Labels
Github Import This was auto-imported from upstream repository type: bug Something isn't working

Comments

@py-mine-bot
Copy link
Collaborator

kevinkjt2000 Authored by kevinkjt2000
Jan 13, 2021
Closed Jan 18, 2021


One of the dependencies has dropped support for 3.5 (as mentioned in #104). Time to re-evaluate whether claiming support for python3.5 is worth it or not. May as well add 3.9 to the supported list too. If support is still necessary for 3.5, the dependency will have to be updated or replaced.

@py-mine-bot
Copy link
Collaborator Author

Iapetus-11 Authored by Iapetus-11
Jan 13, 2021


The dependency that I was talking about would only be a dependency for an async way to check the status of a Bedrock Edition server, sorry if I caused any confusion.

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Jan 13, 2021


Still python 3.5 is already past EOL, so I plan to re-evaluate whether or not to support that going forward.

@py-mine-bot
Copy link
Collaborator Author

Iapetus-11 Authored by Iapetus-11
Jan 13, 2021


Also in addition to being able to add async Bedrock Edition support more easily, since the query protocol uses UDP as well (iirc) we would benefit by being able to do that more easily as well.

@py-mine-bot
Copy link
Collaborator Author

Iapetus-11 Authored by Iapetus-11
Jan 15, 2021


I contacted the developer of asyncio-dgram about if there was a specific reason for not supporting 3.5, and they went and added support for Python 3.5. Relevant issue: jsbronder/asyncio-dgram#6

@py-mine-bot
Copy link
Collaborator Author

Egorrko Authored by Egorrko
Jan 16, 2021


Btw dnspython v2.0 requires python => 3.6 and contains async query and resolver
https://dnspython.readthedocs.io/en/latest/async.html
https://pypi.org/project/dnspython/

@py-mine-bot
Copy link
Collaborator Author

Iapetus-11 Authored by Iapetus-11
Jan 16, 2021


If it is decided to remove support for Python 3.5 I'd make a PR with async lookup functions that utilize the async resolver.

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Jan 16, 2021


3.5 is end of life already; long live python >= 3.6
I’ll raise a PR when I get a moment tomorrow to update Travis job and PyPi metadata. Feel free to ditch 3.5 during testing. Speaking of which, I should probably make a script that runs tests for each version in a local script/tool.

@py-mine-bot py-mine-bot added type: bug Something isn't working Github Import This was auto-imported from upstream repository labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github Import This was auto-imported from upstream repository type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant