Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emdfile version mismatch #458

Closed
sezelt opened this issue Jun 22, 2023 · 2 comments
Closed

emdfile version mismatch #458

sezelt opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sezelt
Copy link
Member

sezelt commented Jun 22, 2023

It seems that in emdfile the RootedNode class was removed in v0.0.9, while it is still imported (and perhaps used?) in py4DSTEM. This seems to be causing the PR build tests to be failing for several open PRs (#456, #455, #441). Currently PyPI is at 0.0.9 and so pip installations of py4DSTEM are broken, but the conda-forge release is one version behind and is working for the moment.

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/work/py4DSTEM/py4DSTEM/py4DSTEM/__init__.py", line 17, in <module>
    from py4DSTEM.classes import (
  File "/home/runner/work/py4DSTEM/py4DSTEM/py4DSTEM/classes/__init__.py", line 5, in <module>
    from py4DSTEM.classes.datacube import DataCube
  File "/home/runner/work/py4DSTEM/py4DSTEM/py4DSTEM/classes/datacube.py", line 6, in <module>
    from emdfile import Array,RootedNode
ImportError: cannot import name 'RootedNode' from 'emdfile' (/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/emdfile/__init__.py)
Error: Process completed with exit code 1.

I am not sure how hard it would be to cut RootedNode out of py4DSTEM and do a hotfix release, versus reverting it in emdfile...

@sezelt sezelt added the bug Something isn't working label Jun 22, 2023
@bsavitzky
Copy link
Member

Yup, should have synced this last emdfile version update yesterday with the associated changes in py4DSTEM. Because I didn't we're getting failed builds in the flaker GH action. PR 459 fixes this - once it's pulled in the other 3 active PRs should pull from dev and the issue should resolve

@bsavitzky
Copy link
Member

Fixed in PR #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants