Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline-snapshot does not support pypy #1534

Closed
15r10nk opened this issue Nov 8, 2024 · 2 comments
Closed

inline-snapshot does not support pypy #1534

15r10nk opened this issue Nov 8, 2024 · 2 comments

Comments

@15r10nk
Copy link

15r10nk commented Nov 8, 2024

It is possible to run the tests, but the problem is to use pytest --inline-snapshot=fix or other options which need access to the ast-nodes.

This is a problem if you want to build pydantic-core with pypy and you have to build and test inline-snapshot also 15r10nk/inline-snapshot#132 (comment).

I created a pull-request which works around this issue #1533.

@15r10nk 15r10nk changed the title inline-snapshot has no pypy support inline-snapshot does not support pypy Nov 8, 2024
@davidhewitt
Copy link
Contributor

Thanks for the heads up, I see you now released 0.14 to handle pypy gracefully. That's good enough for me, I think, will close this. Thanks 👍

@15r10nk
Copy link
Author

15r10nk commented Nov 13, 2024

Thank you. I forgot to close this one, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants