Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ISO 639-1 codes #161

Closed
mdomke opened this issue Apr 5, 2024 · 2 comments
Closed

Add support for ISO 639-1 codes #161

mdomke opened this issue Apr 5, 2024 · 2 comments
Assignees
Labels

Comments

@mdomke
Copy link

mdomke commented Apr 5, 2024

In #141 support for ISO 639-3 and 639-5 language codes was added, but the still very common ISO 639-1 alpha2 format was left out? Is there a reason for this? Otherwise, I could quickly add the missing ISO639_1 type. What do you think?

@mdomke mdomke changed the title Add support for 639-1 codes Add support for ISO 639-1 codes Apr 5, 2024
@yezz123 yezz123 added the Types label Apr 5, 2024
@yezz123
Copy link
Collaborator

yezz123 commented Apr 5, 2024

Hello @mdomke 👋🏻

Thanks for opening this. Yes, with pleasure, you can open a PR and add the ISO639_1 support.

@mdomke
Copy link
Author

mdomke commented Apr 5, 2024

Erm... I think what I was looking for was already implemented in #153. In my opinion we can close this issue, because I second the suggestion to refactor the existing ISO639_3 and ISO639_5 classes into a LanguageAlpha3 class
#153 (comment) .

@yezz123 yezz123 closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants