Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate semantic versioning modules #205

Closed
viccie30 opened this issue Aug 23, 2024 · 1 comment · Fixed by #209
Closed

Duplicate semantic versioning modules #205

viccie30 opened this issue Aug 23, 2024 · 1 comment · Fixed by #209

Comments

@viccie30
Copy link
Contributor

In #195 pydantic_extra_types/semantic_version.py was added, followed by the nearly-identical pydantic_extra_types/semver.py in #199. Would it make sense to deduplicate this useful module?
@yezz123
Copy link
Collaborator

yezz123 commented Aug 23, 2024

Hey @viccie30 nice catch, Yes its make sense 👍🏻

PRs are welcome! 🚀

@07pepa 07pepa mentioned this issue Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ deprecate semver in favor of semantic_version 07pepa/pydantic-extra-types
2 participants
@viccie30 @yezz123