Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font weight heading value seems to be ignored #1212

Closed
vkbo opened this issue Feb 23, 2023 · 3 comments · Fixed by #1213
Closed

Font weight heading value seems to be ignored #1212

vkbo opened this issue Feb 23, 2023 · 3 comments · Fixed by #1213

Comments

@vkbo
Copy link
Contributor

vkbo commented Feb 23, 2023 •
edited
Loading

The variable --pst-font-weight-heading seems is ignored by the heading styles and is instead set to 400.

The screenshot below is from inspecting a h1 heading in the main content section, using 0.12.0.

image

Edit: If this is an actual bug, and not me assuming what the value is for, then I'm happy to provide a fix. I'm testing out this theme for my open source project, and actively tweaking it.
@12rambau
Copy link
Collaborator

Can you check if this bug is also existing in 0.13.0rc3 ?

@vkbo
Copy link
Contributor Author

vkbo commented Feb 23, 2023

It is, I checked RC4. I've fixed it in my custom.css locally, so it should be fairly straightforward to patch.

@12rambau
Copy link
Collaborator

Then please open a PR, the font weight is defined to be used I'm quite surprised it is ignored in the end.

@vkbo vkbo mentioned this issue Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make heading-style use the font-weight-heading value vkbo/pydata-sphinx-theme
2 participants
@vkbo @12rambau