-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ndarray in elemwise again #124
Comments
Meta-comment: My instinctual reaction here is "I don't know" and "we should really get more use cases so that we have a better metric by which to make these decisions". |
In that case, I'll leave this open until such time as we can make these decisions. |
Working on this seems fine to me, I'm mostly just thinking about things we can be doing that are more social and less technical. Maybe generalize CSR and target scipy devs? |
Yes, I'm working on that PEP today. I hope to be done with the PEP soon. I want things to be in a state that SciPy devs would agree to it. I could push my work to the repo, and if you're interested, you can contribute too. I've sent you an invite. |
I'm blocked on this by numba/numba#2560 or #126. |
I was considering allowing
ndarray
underelemwise
again, provided thatf(ndarrays, zeros_in_place_of_COO)
is all-zero.Upsides:
ndarray
inputs at all. This makes it significantly faster for mixed sparse-denseelemwise
.Downsides:
ndarrays
against each other to actually test for densification. This could be huge. Or we can skip this step and risk wrong results.ndarrays
will be tiny compared toCOO
.The text was updated successfully, but these errors were encountered: