Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

CI jobs seem to fail because of rustfmt problems is already-existing code #196

Closed
stevenroose opened this issue May 28, 2020 · 2 comments · Fixed by #192
Closed

CI jobs seem to fail because of rustfmt problems is already-existing code #196

stevenroose opened this issue May 28, 2020 · 2 comments · Fixed by #192

Comments

@stevenroose
Copy link
Contributor

I generally prefer not to enforce formatting on a project, but I accept if projects prefer to do that.

But shouldn't it be made sure that all existing code follows the formatting rules before starting the enforcement?

@pyfisch
Copy link
Owner

pyfisch commented May 28, 2020

But shouldn't it be made sure that all existing code follows the formatting rules before starting the enforcement?

Existing code did follow the formatting rules but rustfmt changed, as you can see in the commit history. No big deal.

I am not sure if you are aware but this crate is looking for a rewrite and a new maintainer (#179). @hansl is working on it but in the meantime I'd rather not spend too much time improving the existing codebase and only fix bugs which severly impact users.

@stevenroose
Copy link
Contributor Author

Hmm, ok makes sense. Feel free to decide whether to merge #192 or just close both the PR and this issue without merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants