Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pyg modules to correctly utilise EdgeIndex #8628

Open
3 tasks
wsad1 opened this issue Dec 16, 2023 · 2 comments
Open
3 tasks

Refactor pyg modules to correctly utilise EdgeIndex #8628

wsad1 opened this issue Dec 16, 2023 · 2 comments
Assignees
Labels

Comments

@wsad1
Copy link
Member

wsad1 commented Dec 16, 2023

🛠 Proposed Refactor

The new EdgeIndex object is a edge_index Tensor with lots of useful metadata. It is a drop in replacement to the usual edge_index Tensor.
The goal of this issue is to refactor pyg to utilise EdgeIndex across all modules. This should make our code more readable, and efficient in many cases.

  • Updates to code where edge_index as sparse matrices are used. Instead leverage the EdgeIndex s matrix multiply operations.
  • Updates to utils. Example sort_edge_index doesn't need to sort EdgeIndex if it is already sorted.
  • Updates to transforms. Example update metadata like is_sorted when using transforms like AddSelfLoops.
@wsad1 wsad1 added the refactor label Dec 16, 2023
@rusty1s rusty1s changed the title Refactor pyg modules to correctly utilise EdgeIndex. Refactor pyg modules to correctly utilise EdgeIndex Dec 28, 2023
@akihironitta
Copy link
Member

@rusty1s I saw your comment in #8700:

EdgeIndex is not yet compatible with torch.compile

Does it mean that we should have this issue on hold for now?

@rusty1s
Copy link
Member

rusty1s commented Jan 5, 2024

No, it just needs some MessagePassing adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants