Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: "db" option for other sampling methods #3137

Closed
rpgoldman opened this issue Aug 6, 2018 · 1 comment
Closed

Feature Request: "db" option for other sampling methods #3137

rpgoldman opened this issue Aug 6, 2018 · 1 comment

Comments

@rpgoldman
Copy link
Contributor

The main sampling method has a way of writing the sample data into files using the db option. But now there are two additional sampling methods, for the prior predictive and posterior predictive, but they produce results of different types (dictionaries, instead of traces), and don't support the db argument. It would be nice to extend their API to be more orthogonal.

Also, I wonder if it's best to have their return values be simple dictionaries instead of some kind of object, because it means there's no place to hang methods for them. For example, there's no place to put a method that will extract points from these results.

@ColCarroll
Copy link
Member

Closed in favor of #2189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants