Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MMM baseclass more basic and show how to subclass and customize #267

Open
ricardoV94 opened this issue May 2, 2023 Discussed in #266 · 3 comments
Open

Make MMM baseclass more basic and show how to subclass and customize #267

ricardoV94 opened this issue May 2, 2023 Discussed in #266 · 3 comments
Assignees
Labels
docs Improvements or additions to documentation MMM priority: medium

Comments

@ricardoV94
Copy link
Contributor

Discussed in #266

Originally posted by bstuddard May 2, 2023
Is it possible to run DelayedSaturatedMMM in an unscaled way? For example, if I'm building a model the has spend dollars for various channels and sales as a target, I'd like to see each coefficient show the impact a dollar spent by channel has on sales.

Looking through the code, I believe each channel and target are scaled using sklearn MaxAbsScaler. If a channel had a max value of $5, while another had a max value of $100 - they would both be showing a 1.0 for the channel x, and resulting coefficients. I don't think this creates any mathematical issues, but makes the results a bit harder to conceptualize (ex betas in terms of individually scaled values).

Any advice on how to approach this? Perhaps something obvious I'm missing.

@ricardoV94 ricardoV94 added the MMM label May 2, 2023
@ricardoV94 ricardoV94 changed the title Unscaled channels and target MMM data transformation May 3, 2023
@ricardoV94
Copy link
Contributor Author

Would be nice to add a doc showing how to tweak these or implement your custom one.

@ricardoV94 ricardoV94 added docs Improvements or additions to documentation priority: medium labels May 3, 2023
@ricardoV94
Copy link
Contributor Author

Also show how to customize the saturation functions

@ricardoV94 ricardoV94 changed the title MMM data transformation Make MMM baseclass more basic and show how to subclass and customize May 3, 2023
@ricardoV94 ricardoV94 self-assigned this May 3, 2023
@wd60622
Copy link
Contributor

wd60622 commented Jun 3, 2024

Related to #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM priority: medium
Projects
None yet
Development

No branches or pull requests

2 participants