Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParetoNBDModel Docstring Typos #727

Closed
ColtAllen opened this issue Jun 9, 2024 · 2 comments · Fixed by #750
Closed

Fix ParetoNBDModel Docstring Typos #727

ColtAllen opened this issue Jun 9, 2024 · 2 comments · Fixed by #750
Labels
CLV docs Improvements or additions to documentation good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance priority: low

Comments

@ColtAllen
Copy link
Collaborator

While working on #527, I noticed some docstring typos and syntax errors for ParetoNBDModel. The docstrings in BetaGeoModel follow an identical convention and are error-free, so this would be a very quick PR fix.
@ColtAllen ColtAllen added docs Improvements or additions to documentation good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package CLV maintenance no releasenotes priority: low and removed no releasenotes labels Jun 9, 2024
@Mews
Copy link
Contributor

Mews commented Jun 10, 2024

I took a look at the docstrings and I fixed a few typos but I'm not sure if I got everything
I'll open a PR anyway so that you can take a look

@Mews Mews mentioned this issue Jun 10, 2024
Merged
12 tasks
@juanitorduz
Copy link
Collaborator

I took a look at the docstrings and I fixed a few typos but I'm not sure if I got everything I'll open a PR anyway so that you can take a look

Thanks for the PR! We can work on iterations :)

@OriolAbril OriolAbril mentioned this issue Jun 14, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLV docs Improvements or additions to documentation good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

start addressing sphinx warnings and rendering issues OriolAbril/pymc-marketing
3 participants
@ColtAllen @juanitorduz @Mews