From 1d1f63931ead7e7bb0850e607eccb11f617bf736 Mon Sep 17 00:00:00 2001 From: Alex Ruddick Date: Tue, 11 Apr 2023 13:45:56 -0500 Subject: [PATCH 1/2] Remove obsolete B325 --- bandit.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/bandit.yaml b/bandit.yaml index b3b28c019..8a7a419bf 100644 --- a/bandit.yaml +++ b/bandit.yaml @@ -17,7 +17,6 @@ tests: - B318 - B319 - B320 - - B325 - B601 - B602 - B604 From 02c197bda0ac6cd7d0f0e86d8864ff9269d8f750 Mon Sep 17 00:00:00 2001 From: Alex Ruddick Date: Tue, 11 Apr 2023 13:46:14 -0500 Subject: [PATCH 2/2] Move bandit from its own CI to pre-commit --- .github/workflows/ci.yml | 5 +---- .pre-commit-config.yaml | 5 +++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 16e1fbd52..61911c46f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,10 +31,7 @@ jobs: - name: codespell cmd: codespell type: lint - - name: bandit - cmd: bandit -r -c bandit.yaml . - type: lint - - name: precommit (isort, black, and ruff) + - name: precommit (black, bandit, and ruff) cmd: pre-commit run --all-files type: lint - name: docs diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 75b1f2410..b5d35cb10 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -22,3 +22,8 @@ repos: - id: black args: [--safe, --quiet] files: (examples|pymodbus|test)/ +- repo: https://github.com/PyCQA/bandit + rev: 1.7.5 + hooks: + - id: bandit + args: [-c, bandit.yaml]