Better type hints

[Ipuch]

With @pariterre, we think that we should migrate to global type hints:

currently we have such hints:

def function(entry: list[int] | tuple[int]):
      return None

Instead, we would like:

ListLikeInt = list[int] | tuple[int]
def function(entry: ListLikeInt):
      return None

[EastWest14]

@Ipuch I got this. You want to change in every python file?

[pariterre]

@EastWest14
With great pleasure 🙂

Could you first create a PR for a single file with the proposed naming for the all (or most of) the list/tuple (and other typing names that you can think of)? Once we agreed with the naming with @Ipuch , you could change it everywhere. This new file should be misc/types.py

Thanks a lot!

[EastWest14]

@pariterre @Ipuch Here is a draft for one tiny file:
link(https://github.com/pyomeca/bioptim/pull/928/files)

Where should I put the file with all the type names?

[EastWest14]

@pariterre @Ipuch Do you want me to continue with PRs for other modules? Happy to keep working on this

[pariterre]

Definitely :)

[Ipuch]

That's a great idea ! Great work by the way ;)
TBH, I'm curious, how did you find the repo and the issue ?

[EastWest14]

Ok, there are about 6 big modules - I'll be going one by one. Will take about 2-3 days per module.
Will post PRs as they come up and tag you here.

I found it in Github search for open issue and "good first issue".