xosc.ParseOpenScenario expects optional Event/startTrigger

[zwergziege]

In OpenScenario V1.2 Event/startTrigger is optional and set to the start condition of the enclosing Act if missing. The current implementation of xosc.ParseOpenScenario fails if this child element is missing.
Edit: corrected wrong child name

[mander76]

Could you provide an example?

The only optional is the ConditionGroup when it comes to triggers, not Conditions.
However there is an issue that you cannot have an trigger without conditionsgroups, when creating the xosc, that I'll fix.

[zwergziege]

I'm talking about Event not Trigger, but I specified the wrong child. It's actually Event/startTrigger not Event/startCondition. I fixed it above.
According to the spec, the following is a valid event

<Event name="Event" priority="skip">
   <Action name="Action">
   </Action>
</Event>

However, parsing it should fail since Event.parse - lacking startTrigger - calls Trigger.parse(null) which throws.

[mander76]

Aha, now it's clearer. Thanks. I'll fix that.

[mander76]

https://github.com/pyoscx/scenariogeneration/tree/parsing_act_issue
Check if it works as expected

[zwergziege]

The change should not work since it still calls Trigger.parse(element.find("StartTrigger")) unconditionally, which fails if the event does not have a startTrigger. You should check whether the result of elementfind("StartTrigger") is not null and only then try to parse and append it to the event.

[mander76]

Sorry for the late update, now there is a new push in the same branch.