-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip fails to install in-house wheel on Mac OS 11 #335
Comments
You thought correctly, 10.12 is meant to indicate the minimal version, but I think the tag logic uses something like semantic versioning. Since nobody knows what macOS 11 looks like before it actually happened, it was assumed to be backwards incompatible, and thus wheels built on 10.12 was assumed to be incompatible to 11.0. We should transfer this issue to pypa/packaging @pradyunsg |
/cc @brettcannon I guess? |
@uranusjr I think that seems that is the wrong approach to take, does it not? 🤔 . Basically having any pip package built on 10 will not work on future major version OS version seems to be the wrong approach.. it is just like building an app with minor version 10.12... Any future OS should run unless Apple says otherwhise. It is like when they drop 32... If a customer try to run a 32 app, the OS will complain that is not supported. |
It's because this is for macOS 11 and we don't have support for that version yet. See #319 and https://discuss.python.org/t/apple-silicon-and-packaging/4516. Closing as a duplicate of #318 |
For completeness, the current implementation is most certainly not a wrong approach to take. Nobody knows whether macOS 11 would be compatible with 10.x before it came out (except maybe a very small group of people in Apple who don’t involve in Python packaging at all), and the only sensible way to do this is to assume it’s incompatible. If the new version ends up being compatible (as things turns out), we can just release a new pip version for everyone on the new version. If things were assumed to be compatible and but turns out not so, we would have no way to retrospectively prevent people from installing incompatible wheels on macOS 11. That would be a disaster for everybody. |
@uranusjr hmmm... Not sure if I agree 100% with that. Although, I understand what you are saying, then I would argue: If the concern is to avoid having people to install incompatible wheels on Mac OS 11, then why this is already sort of allowed to be done by just upgrading from 10 to 11. Basically, if I have a mac 10 with my pre existing pip packages already installed there, and I decided to upgrade to 11 beta, my pip packages will work continue to work. And I mentioned this because we already tried to do ths in an existing machine we have. We didn't stumble upon any problem until we decided to try in full clean mac 11 machine. Unless we just were lucky 🤔 Anyways, I trust you guys 😁 |
We have an in-house wheel package that we maintain and were testing the wheel on Mac OS 11, when I tried to install my wheel I go the following error
Looking through the verbose output, I get:
pti-2.1.621-py3-none-macosx_10_12_x86_64.whl -> I always looked
10_12
as min os version, but reading through https://www.python.org/dev/peps/pep-0425/#id13, now that makes me think it is just the version of the mac os version thw wheel was built under which doesn't match what MacOS 11 is looking forDoes this mean that any wheel built on Mac 10.X.X will not work unless those wheel are built on 11? Or is this something be addressed in the coming release for pip?
The text was updated successfully, but these errors were encountered: