pip install upgrade will not upgrade package if extras_require specified.

[wangchao1230]

Description

# suppose we have installed a old package version like below
pip install azureml-dataprep[pandas]==2.15.1

# NOT EXPECTED: this command will not upgrade if the [pandas] extras_require specified
pip install azureml-dataprep[pandas] --upgrade

# this command will upgrade the package version
pip install azureml-dataprep --upgrade

Expected behavior

# this command will upgrade if the [pandas] extras_require specified
pip install azureml-dataprep[pandas] --upgrade

pip version

21.1.3

Python version

Python 3.7.6

OS

Windows

How to Reproduce

See description part.

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[domdfcoding]

I can reproduce with pip 21.1.x but not with 21.0.1 and not with main.

I have tracked the issue down to 778778c; prior to that it works as expected.
It seems to be working correctly again after 73edd74

I don't know whether a 21.1.4 release is planned, but 21.2 should be out soon (follow #10106 for updates). In the interim downgrading to 21.0.1 should work around this.

[wangchao1230]

Thanks Dominic for the info!

[uranusjr]

I took a look at the changes (thanks @domdfcoding for the additional info, that saved me a ton of time!) and it seems the previous implementation “worked” accidentally because we were handling packages with extras incorrectly. 778778c fixed that handling but unfortunately broke the accidental code path that made this work. 73edd74 then implemented a proper code path (for something else about extras that never worked) and incidentally also correctly handled the issue.

Extras are the worst 🙄

@wangchao1230 Would you be interested in contributing a test case so we don’t accidentally break this in the future? A test function in tests/functional/test_new_resolver.py would be most appropriate, and you can find many examples how to write such a test in that file.

[no-response]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.