Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install script warnings should ignore dirname(sys.executable) #5157

Closed
pradyunsg opened this issue Apr 3, 2018 · 1 comment
Closed
Assignees
Labels
auto-locked Outdated issues that have been locked by automation type: bug A confirmed bug or unintended behavior
Milestone

Comments

@pradyunsg
Copy link
Member

From #4553 (comment)

this is a common use case this PR did not cover.

if the executable is installed in dirname(sys.executable), we can skip the warning. Basically, treat dirname(sys.executable) as being a directory on PATH.

The "use case" above, is of installation using venv/bin/pip when invoking without activating a virtualenv.

@pfmoore doesn't feel strongly either way. @ncoghlan is in favour.

@pradyunsg pradyunsg added type: bug A confirmed bug or unintended behavior !release blocker Hold a release until this is resolved labels Apr 3, 2018
@pradyunsg pradyunsg added this to the 10.0 milestone Apr 3, 2018
@pradyunsg pradyunsg self-assigned this Apr 4, 2018
@pradyunsg pradyunsg removed !release blocker Hold a release until this is resolved labels Feb 8, 2019
@lock
Copy link

lock bot commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant