Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv --venv takes 0.5 sec #2483

Closed
jabbalaci opened this issue Jun 30, 2018 · 3 comments
Closed

pipenv --venv takes 0.5 sec #2483

jabbalaci opened this issue Jun 30, 2018 · 3 comments
Labels
Category: Future Issue is planned for the future. Category: Performance Issue relates to performance

Comments

@jabbalaci
Copy link

pipenv --venv is quite slow:

$ time pipenv --venv
...
real    0m0.496s
user    0m0.450s
sys     0m0.046s

Why is it so slow? Is there a way to speed it up?

@uranusjr
Copy link
Member

uranusjr commented Jun 30, 2018

Why is it so slow?

Because the implementation is not optimal.

Is there a way to speed it up?

Yes.

Is there a lot of time available to invest on it?

Not really.

Do lend a hand if you’d like to.

@uranusjr uranusjr added Category: Future Issue is planned for the future. Category: Performance Issue relates to performance labels Jun 30, 2018
@techalchemy
Copy link
Member

This is fixed in #2485 --

 ~/g/pypa-pipenv       pipenv --version
pipenv, version 2018.7.1
 ~/g/pypa-pipenv       time -p pipenv --venv
/home/hawk/.virtualenvs/pypa-pipenv-PuUpLSqX-3.7
real 0.12
user 0.10
sys 0.02

@jabbalaci
Copy link
Author

Thank you, it's fixed now. Here are my results:

Before:

$ time pipenv --version
pipenv, version 2018.6.25

real    0m0.486s
user    0m0.456s
sys     0m0.030s
=======================================================================
$ time pipenv --venv
/home/jabba/...

real    0m0.485s
user    0m0.455s
sys     0m0.030s

After:

$ time pipenv --version
pipenv, version 2018.7.1

real    0m0.111s
user    0m0.101s
sys     0m0.010s
=======================================================================
$ time pipenv --venv
/home/jabba/...

real    0m0.108s
user    0m0.102s
sys     0m0.007s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Future Issue is planned for the future. Category: Performance Issue relates to performance
Projects
None yet
Development

No branches or pull requests

3 participants