Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2018.10.13 tag points to wrong version #3098

Closed
nijave opened this issue Oct 25, 2018 · 6 comments
Closed

v2018.10.13 tag points to wrong version #3098

nijave opened this issue Oct 25, 2018 · 6 comments
Assignees

Comments

@nijave
Copy link

nijave commented Oct 25, 2018

Issue description

git clone https://github.com/pypa/pipenv.git
cd pipenv
git checkout v2018.10.13
cat pipenv/__version__.py

Expected result

#     ___     ( )  ___      ___       __
#   //   ) ) / / //   ) ) //___) ) //   ) ) ||  / /
#  //___/ / / / //___/ / //       //   / /  || / /
# //       / / //       ((____   //   / /   ||/ /
__version__ = "2018.10.13"

Actual result

#     ___     ( )  ___      ___       __
#   //   ) ) / / //   ) ) //___) ) //   ) ) ||  / /
#  //___/ / / / //___/ / //       //   / /  || / /
# //       / / //       ((____   //   / /   ||/ /
__version__ = "2018.10.14.dev0"

Steps to replicate

clone repo
checkout v2018.10.13 tag
check version file

Looks like the v2018.10.13 tag is attached to the wrong commit. The v2018.10.9 tag appears correct. This makes it difficult to build this specific version

@techalchemy
Copy link
Member

It was tagged late while I was on vacation, it is identical in every other way.

@nijave
Copy link
Author

nijave commented Oct 25, 2018

Issue is I'm trying to automatically build a wheel and checking out v2018.10.13 and building results in a wheel with the wrong version in the name so I'd need to put a manual workaround in place to fix that specific version

I am trying to workaround this Artifactory bug https://www.jfrog.com/jira/browse/RTFACT-16189

@techalchemy
Copy link
Member

Ah ok I can push the right tag in a bit, apologies. The only difference is the version in the version file I just tagged out of order because I was on vacation / not using my normal tooling

@techalchemy techalchemy self-assigned this Oct 30, 2018
@nijave
Copy link
Author

nijave commented Oct 30, 2018

Awesome, thanks!

@homocomputeris
Copy link

homocomputeris commented Jan 25, 2020

@techalchemy 2018.11.26 also has a wrong version:

__version__ = "2018.11.15.dev0"

So, when installed from GitHub, not PyPI, it gives:

$ pipenv --version
pipenv, version 2018.11.15.dev0

@homocomputeris
Copy link

#3326 seem to be more or less the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants