Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating requirements.txt re-calculates the lock file #4539

Closed
jacobeatsspam opened this issue Nov 18, 2020 · 5 comments
Closed

Creating requirements.txt re-calculates the lock file #4539

jacobeatsspam opened this issue Nov 18, 2020 · 5 comments

Comments

@jacobeatsspam
Copy link

This is a blatant duplicate of #3975 because @frostming doesn't seem to be responding there.

This is a critical issue that breaks a lot of common workflows. Can this please get some attention?

@frostming
Copy link
Contributor

This is a behavioral change, but I think OP can be achieved by pipenv lock -r --skip-lock.

@jacobeatsspam
Copy link
Author

@frostming Thanks for taking a look. I'll give that a try. For some reason I recall running into a bug with this, but can't recall the details right now.

@frostming
Copy link
Contributor

My bad pipenv lock doesn't have that option, maybe simply add that flag is okay?

@jacobeatsspam
Copy link
Author

jacobeatsspam commented Nov 23, 2020

@frostming Found the issue I was thinking of when making my last comment. You'll want to read the comments following mine which explain some of the issues.

My bad pipenv lock doesn't have that option, maybe simply add that flag is okay?

I think that would be great! Maybe also a ticket for another flag to include the associated package hash (--hash)?

@matteius
Copy link
Member

matteius commented Apr 22, 2022

@jacobisaliveandwell new versions of pipenv have a requirements command to generate the requirements.txt and this will likely eventually completely replace the pipenv lock -r behavior or at least that could lock and then run the requirements command, but the requirements command simply introspects the Pipfile.lock. Including hashes is one of the flags available for the new command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants