TST: mask warning in test_cf_from_numpy_dtypes #783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 21 21
Lines 1528 1528
=======================================
Hits 1447 1447
Misses 81 81 Continue to review full report at Codecov.
|
| @@ -51,19 +51,20 @@ def test_cf_from_numpy_dtypes(): | |||
| "latitude_of_projection_origin": numpy.int(45), | |||
There was a problem hiding this comment.
Instead of masking the warning, I think the "proper" fix is to change the above to numpy.int64(45) (because the above usage of np.int() is deprecated)
There was a problem hiding this comment.
The warning masked is the one about losing CRS information raised by pyproj when exporting to PROJ string. That is good to know about the numpy deprecation. If you have a moment to raise an issue or open a quick PR with the fix, that would be helpful. Thanks 👍
There was a problem hiding this comment.
Ah, yes, stupid me, of course the warning you were fixing wasn't coming from here, since the pytest.warns is only below ;)
(but indeed, something to fix anyway, and I see you already did a PR!)
TST: mask warning in test_cf_from_numpy_dtypes (pyproj4#783)
Continuation of #775