Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve gradient computation of eucledian kinetic energy #567

Closed
fehiepsi opened this issue Apr 7, 2020 · 0 comments · Fixed by #883
Closed

improve gradient computation of eucledian kinetic energy #567

fehiepsi opened this issue Apr 7, 2020 · 0 comments · Fixed by #883
Labels
enhancement New feature or request
Milestone
0.5

Comments

@fehiepsi
Copy link
Member

fehiepsi commented Apr 7, 2020

I have been wanted to do this for a while. Given the recent improvement in JAX regarding custom derivatives, it is time to make this enhancement. Currently, kinetic_energy is defined as x.T @ M @ x, which has an analytical grad formula (we will use this instead of relying on grad). This is just a small optimization but would be useful for the dense_mass case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Improve kinetic energy gradient computation for eucleadian kinetic energy fehiepsi/numpyro
1 participant
@fehiepsi