PytestDeprecationWarning regarding DescribeBlock with pytest 5.4

[Cito]

With the latest pytest 5.4 I start getting the following warnings:

.tox/py36/lib/site-packages/pytest_describe/plugin.py:149: PytestDeprecationWarning:
  direct construction of DescribeBlock has been deprecated,
  please use DescribeBlock.from_parent return DescribeBlock(obj, collector)

[Cito]

Note that there are also warnings like PytestDeprecationWarning: TerminalReporter.writer attribute is deprecated, use TerminalReporter._tw, but I think this is a pytest issue.

[Cito]

See also the 5.4 list of deprecations regarding this change.

[ropez]

@Cito Unfortunately, I haven't programmed I python in almost three years. If anyone is able to submit a PR, I will be happy to create a new version, but I'm afraid I won't have time to resolve these issues myself.

[Cito]

Too bad. But thank you for the feedback. Sadly, I cannot help either - too many other things going on already, and I fear this needs some deep diving into pytest plugin programming.

Please, if anybody else can help out here, that would be great.

[jacebrowning]

I can take a look this weekend.

[jacebrowning]

@ropez It's not a complete blocker, but getting #25 merged first will make fixing this warning easier.

[jacebrowning]

#27 contains the patch.

I've confirmed this eliminates the PytestDeprecationWarning by installing the patch into a couple of my projects.

[ropez]

@Cito @jacebrowning Would it be possible for any of you to just take over the responsibility for this? It has been just working for several years, so it's not really much to do, except for the occasional compatibility issue.

[Cito]

You mean the responsibility for the whole project? Including releasing on PyPI or would you still do that?

[ropez]

Yes, I meant the whole project. I'm sure it's possible to add access to PyPi.

[Cito]

Yes, you can simply add new owners or maintainers (who can only publish but not delete releases) on PyPI. Regarding GitHub, it's probably best to transfer the project to the pytest-dev organization instead to another person. The current repository address ropez/pytest-describe will then be automatically forwarded by GitHub to pytest-dev/pytest-describe. I guess it's best to ask on [email protected] if they can initiate the transfer. Do you want to do that or shall I ask on your behalf? I can take over maintenance if nobody else volunteers, since I would hate to see this project die, but if @jacebrowning or somebody on the pytest-dev mailing list volunteers, or we could share the responsibility, I would be happier.

[jacebrowning]

I'm not yet part of the pytest-dev organization, but I'm willing to help make releases if we can get it transferred there.

[ropez]

@Cito Sounds great! I would be very happy if you could initiate this. I also wouldn't like to see this die, even if I'm not able to maintain it.

[Cito]

Ok, I just asked on the mailing list and hope we will hear back from someone in the pytest-dev org.

[Cito]

We now got a +1 from a pytest-dev developer, who also pointed to the official documentation for submitting plugins to pytest-dev, but we need another +1 to initiate the transfer.

You will also need to make @jacebrowning and me additional maintainers on PyPI, so that we have the minimum number of 3 people who can publish releases.

[Cito]

@ropez We now have two +1 from pytest-dev, so looks like we can start the transfer.

I have created a separate issue #30 to track the progress of the transfer, let's move this discussion there.