-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run ci against gevent/greenlet monkeypatching #3510
Comments
Gave this a quick shot on master by creating from gevent import monkey
monkey.patch_all() Unfortunately that doesn't break the tests. Any ideas? |
@nicoddemus isn't master already fixed, prior to your patch it should fail this is mainly intended to catch minor issues |
I tried the above without the fix for gevent. |
oh, extra fun then |
or perhpas its precisely because we patched too early what happens if the monkeypatch happens after pytest is initialized but before tests are executed |
When the conftest is imported pytest has been initialized already, so that's been tried. I also tried to patch even early by using a wrapper script: from gevent import monkey
monkey.patch_all()
import pytest
pytest.main() But still no good. 😕 |
i see, interesting |
closing as not actionable - if the next one comes up we can try again, this one was on the bench for long enough |
#3503 demonstrated that testing against stdlib-patchers provides a safety net for users
The text was updated successfully, but these errors were encountered: