Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run ci against gevent/greenlet monkeypatching #3510

Closed
RonnyPfannschmidt opened this issue May 25, 2018 · 9 comments
Closed

run ci against gevent/greenlet monkeypatching #3510

RonnyPfannschmidt opened this issue May 25, 2018 · 9 comments
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@RonnyPfannschmidt
Copy link
Member

#3503 demonstrated that testing against stdlib-patchers provides a safety net for users

@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #3423 ([Feature request] Colorized output when run in CI), #2544 (Run tests truly programmatically), #481 (Running doctests with -s fails?), #1985 (Monkeypatching "compile" breaks pytest sometimes), and #1484 (running py.test).

@nicoddemus nicoddemus added the type: infrastructure improvement to development/releases/CI structure label May 25, 2018
@nicoddemus
Copy link
Member

Gave this a quick shot on master by creating testing/conftest.py:

from gevent import monkey
monkey.patch_all()

Unfortunately that doesn't break the tests. Any ideas?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus isn't master already fixed, prior to your patch it should fail

this is mainly intended to catch minor issues

@nicoddemus
Copy link
Member

I tried the above without the fix for gevent.

@RonnyPfannschmidt
Copy link
Member Author

oh, extra fun then

@RonnyPfannschmidt
Copy link
Member Author

or perhpas its precisely because we patched too early

what happens if the monkeypatch happens after pytest is initialized but before tests are executed

@nicoddemus
Copy link
Member

what happens if the monkeypatch happens after pytest is initialized but before tests are executed

When the conftest is imported pytest has been initialized already, so that's been tried. I also tried to patch even early by using a wrapper script:

from gevent import monkey
monkey.patch_all()
import pytest
pytest.main()

But still no good. 😕

@RonnyPfannschmidt
Copy link
Member Author

i see, interesting

@RonnyPfannschmidt
Copy link
Member Author

closing as not actionable - if the next one comes up we can try again, this one was on the bench for long enough

@RonnyPfannschmidt RonnyPfannschmidt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

No branches or pull requests

3 participants