Automatically stop console output capturing when pudb is used

[pytestbot]

Originally reported by: BitBucket: vmalloc, GitHub: vmalloc

---

Currently py.test correctly identifies when pdb kicks in and temporarily stops output capturing. This also works for ipdb AFAIK. When trying to use pudb to debug or set_trace in running code, the output capturing is not turned off, thus causing an error. It would be nice for pudb to be recognized as well.

---

• Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/647

[pytestbot]

Original comment by holger krekel (BitBucket: hpk42, GitHub: hpk42):

---

if you can please try to contribute a PR which makes pudb work (_pytest/pdb.py and testing/test_pdb.py are the relevant files i guess, maybe _pytest/capture.py as well)

[RonnyPfannschmidt]

Closing as stalled

[benjaminweb]

if pudb.set_trace() is called from a test function, pytest should set the options -s --capture=no.
Or at least elicit a warning indicating the user would want these command line switches to make pudb work.

If I had learned about these switches earlier, I would have used pudb earlier — which I sincerely wished! I consider this to be essential.

If nothing seems reasonable, a mention in the doc would be highly appreciated.

[RonnyPfannschmidt]

@benjaminweb pdb is explicitly supported since its in the stdlib - other debuggers added support code for pytest (pdbpp), or pytest plugins where written (pytest-ipdb) for example

also pytest supports declaring a pdb class, in which case pytest.set_trace is invoked does the pytest support and defers the rest to the actual debugger

also the cli options are unrelated to debugger integration, using those just makes it easier to use unsupported tools

a integrated debugger disables capture while debugging and then re-enables it

[twmr]

@RonnyPfannschmidt is the pytest pdb class stuff mentioned in the docs somewhere? I've only found https://docs.pytest.org/en/latest/usage.html#setting-breakpoints, which only mentions the stdlib pdb module.

[benjaminweb]

pytest-ipdb is no longer maintained.

@RonnyPfannschmidt so, the lacking pudb integration is due to that pudb seems not to declare a pdb class? can we verify this and delegate the issue if applicable to them? Ah, I see there is already an issue pending: inducer/pudb#221

What needs to be done to get the implementation with pytest right?

The current approach still seems to require the -s switch: inducer/pudb#224

[nicoddemus]

@Thisch indeed the --pdbcls option is not mentioned anywhere in the docs, created #3141.

[nicoddemus]

What needs to be done to get the implementation with pytest right?

inducer/pudb#224 suggest this has been done already. cc @inducer

[inducer]

inducer/pudb#224 just concerns passing on exceptions correctly. I haven't tested debug-on-test-fail with pytest and pudb, so I don't know whether it works as intended. (Although I am a heavy user of pytest, so thank you!)