-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default regex mode use regress
for JS-flavor regex format validation
#302
Comments
(I would maybe name the regress one js or ecma or ecmascript or javascript or whatever personally, so users don't need to even know what the heck regress is, but that's probably the easy part!) |
I have to stash my work on this for now, but I'll be keeping an eye on I took a quick crack at a PR for this: ridiculousfish/regress#67 I think that fix is right; if it or an alternative fix gets merged, I can try to put in a PR to prep a release of |
My PR was merged just under a week ago, but I'm not sure what the |
This is now in Because we might have a way for It's still very much wired up to format checking, but it should be easy to move elsewhere and grow it as new features become available. |
There's a python package for the
regress
crate (see: python-jsonschema/jsonschema#1142 (comment)).It should be pretty easy to pull this in and use it to replace the default regex format check.
We can then expose many modes with something like
--regex-format [default|regress|python|disabled]
and drop the gated regex check that exists today. (Wheredefault
andregress
are the same?)There's other CLI option refactoring to do around the format controls, so this might dovetail with that.
The text was updated successfully, but these errors were encountered: