Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small feature request for 'poetry shell' to accept something besides $SHELL #947

Closed
2 tasks done
floer32 opened this issue Mar 10, 2019 · 3 comments
Closed
2 tasks done

Comments

@floer32
Copy link

floer32 commented Mar 10, 2019

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Small setback

If poetry shell is run from a script, then $SHELL is going to be set to what that script was executed in. Example scenario:

  • I am using zsh
  • I write scripts to help teammates work with Poetry (they are coming from other tools), for example a .env which gets sourced by autoenv etc, and then does poetry shell at the end. I make these scripts have a bash shebang because that's the sane default for most at the company
  • I still want to be using zsh when poetry shell is called in one of these contexts

Easy fix

  • Option: support for $POETRY_SHELL variable that will be checked before $SHELL variable
    • This option seems sensible to me
  • Option: support for something like poetry shell --precedence /bin/zsh /bin/bash etc
  • Option: support for something like that, but at poetry config level

I will submit a PR once we agree on how it should work!

@floer32 floer32 changed the title Small feature request for 'poetry shell' preferences Small feature request for 'poetry shell' to accept something besides $SHELL Mar 10, 2019
@floer32
Copy link
Author

floer32 commented Mar 12, 2019

(It would also be reasonable for run to respect the same, though it makes no difference for my use case)

@floer32
Copy link
Author

floer32 commented Mar 15, 2019

Closing as redundant of #571 / #497 / #951

@floer32 floer32 closed this as completed Mar 15, 2019
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant