Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging in with GitHub #7

Closed
Mariatta opened this issue Jun 15, 2018 · 7 comments
Closed

Support logging in with GitHub #7

Mariatta opened this issue Jun 15, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@Mariatta
Copy link
Member

It would be great if we can login to bpo using GitHub.

Thanks.

@brettcannon brettcannon added the enhancement New feature or request label Jun 18, 2018
@ammaraskar
Copy link
Member

ammaraskar commented Jun 20, 2018

Setup Instructions

Generate a set of github oauth credentials here:
https://github.com/settings/applications/new

Set the authorization callback url to be:
https://bugs.python.org/index?@action=oic_authresp&provider=Github

Insert the client_id and client_secret into the database:

INSERT INTO _oic_registration 
  (_issuer, _client_id, _client_secret, id) 
  VALUES ('https://github.com/settings/developers', 'xx', 'xx', x);

Patch

Applies to tracker/python-dev

https://gist.github.com/ammaraskar/e259bc7d50df354e796e3c0d61137b10

@ammaraskar
Copy link
Member

@ezio-melotti Antoine said you'd be the right person to talk to about getting this merged. Lemme know if you want the patch in some specific way or another.

@ewdurbin
Copy link
Member

A GitHub application managed by the python organization has been created with the name bugs.python.org and configured as directed above.

@Mariatta
Copy link
Member Author

Mariatta commented Aug 8, 2019

I still have not figured out how to register/login to bpo using GitHub account 😟
Has the patch been merged? @ammaraskar @ezio-melotti?

@Mariatta Mariatta reopened this Aug 8, 2019
@ammaraskar
Copy link
Member

@berkerpeksag might also be able to answer, I think they mentioned this was disabled for some reason.

@berkerpeksag
Copy link
Member

It wasn't fully deployed for end users. By default, GitHub API doesn't include email addresses of users even if we set the OAuth scope correctly (users need to make their email address public on GitHub or we need to make a request to another endpoint in order to get their email address)

I'm not going to work on it until I get a response from Barry regarding PEP 595.

@berkerpeksag
Copy link
Member

I've just re-pushed the patch with some modifications. I've already tested both Google and GitHub login supports locally. It should detect and associate existing bugs.python.org accounts with the same email address.

The only limitation is that the email address must be set to public in user's email settings at GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants