Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test cases to skip rerun #105310

Closed
sunmy2019 opened this issue Jun 5, 2023 · 4 comments
Closed

Allow test cases to skip rerun #105310

sunmy2019 opened this issue Jun 5, 2023 · 4 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@sunmy2019
Copy link
Member

sunmy2019 commented Jun 5, 2023

Currently, there are some tests with intentional leaks or some other tests that do not support rerun.

Adding this decorator will help to resolve this edge case.

inspired by #105122

Linked PRs

@sunmy2019 sunmy2019 added the type-feature A feature request or enhancement label Jun 5, 2023
@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Jun 5, 2023
@Eclips4
Copy link
Member

Eclips4 commented Jun 5, 2023

Interesting. Can be #105273 resolved if we decorate test_capi/test_misc/TestOptimizerAPI.test_counter_optimizer?

@erlend-aasland
Copy link
Contributor

After thinking about this for some weeks, I'm -1 on the idea. I don't think we should make it easier to skip reruns. Unfortunately, adding machinery to test.support will exactly do that; hence my -1.

I'm sorry to have urged you to open this issue in the first place. However, I changed my mind.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Jun 19, 2023
@sunmy2019
Copy link
Member Author

That's fine. I think we can leave this issue open and close the PR.

@erlend-aasland
Copy link
Contributor

Let's not encourage making it easier to skip reruns; let's close the issue.

@erlend-aasland erlend-aasland closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants