-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify logging.handlers.SysLogHandler behavior with SocketHandlers #88457
Comments
Probably we should make the behavior of SysLogHandler consistent with other Socket handlers. Right now SocketHandler and DatagramHandler implement such behavior:
SysLogHandler doesn't implement this behavior and when you close the socket for some reason (eg. restart of uWSGI server on code change) it leaves it in the closed state, then raises an error when you try to send any message because it is closed
|
UPD: right now it has reconnection logic for unixsocket but not for tcp/udp |
Should it not have UDP/TCP supported as well as domain sockets, before being reviewed? |
Oh, sorry bad wording. The current implementation has reconnection logic only for UNIX sockets I've done it with minimal changes to the existing code to accomplish that. And probably it can be merged. But in general, it looks like we can refactor SysLogHandler to inherit from SocketHandler. Not sure if it should be done in this PR or better to create separate? |
OK, I see. Will take a look soon.
Better a separate PR for that, I feel. Removing the older Pythons from the issue, as this is an enhancement request. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: