Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum.EnumMeta renaming #93064

Closed
JelleZijlstra opened this issue May 22, 2022 · 1 comment
Closed

enum.EnumMeta renaming #93064

JelleZijlstra opened this issue May 22, 2022 · 1 comment
Assignees
Labels
3.11 only security fixes

Comments

@JelleZijlstra
Copy link
Member

#22392 renamed the enum.EnumMeta metaclass to enum.EnumType. This originally went into 3.10 and was reverted (#27010), but remained on 3.11.

The renaming caused some problems for me with introspection code that looks at the name of classes to find their stubs (quora/pyanalyze#537).

I don't see anything wrong with the old name (EnumMeta). Could we return to the EnumMeta name to avoid gratuitously making upgrades harder?

cc @ethanfurman for enum

@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error 3.11 only security fixes labels May 22, 2022
@ethanfurman ethanfurman removed the type-bug An unexpected behavior, bug, or error label May 23, 2022
@ethanfurman
Copy link
Member

My apologies for the extra work. I renamed it (and kept the old name as an alias) because I personally found it confusing when working with enums to have, for example, SelectionEnum be of type EnumMeta and not EnumType.

The change is not gratuitous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes
Projects
None yet
Development

No branches or pull requests

2 participants