bpo-44362: ssl: improve deprecation warnings and docs (GH-26646) #26646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
docs
graingert
reviewed
Jun 10, 2021
Modules/_ssl.c
Outdated
| @@ -3583,7 +3593,7 @@ set_options(PySSLContext *self, PyObject *arg, void *c) | |||
| set = ~opts & new_opts; | |||
|
|
|||
| if ((set & opt_no) != 0) { | |||
| if (_ssl_deprecated("Setting OP_NO_SSL* or SSL_NO_TLS* options is " | |||
| if (_ssl_deprecated("Setting OP_NO_SSL*/ssl.SSL_NO_TLS* options is " | |||
There was a problem hiding this comment.
Suggested change
| if (_ssl_deprecated("Setting OP_NO_SSL*/ssl.SSL_NO_TLS* options is " | |
| if (_ssl_deprecated("Setting ssl.OP_NO_SSL*/ssl.SSL_NO_TLS* options is " |
graingert
reviewed
Jun 10, 2021
Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-44362-ssl-depr
branch
from
f656ee3 to
24096d7
Compare
graingert
approved these changes
Jun 10, 2021
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
tiran
changed the title
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit e26014f) Co-authored-by: Christian Heimes <[email protected]>
|
GH-26665 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit e26014f) Co-authored-by: Christian Heimes <[email protected]>
pquentin
added a commit
to elastic/rally
that referenced
this pull request
May 19, 2022
Rally is a client, so its purpose is to authenticate servers. This means that we should use ssl.Purpose.SERVER_AUTH instead of CLIENT_AUTH, with or without client certs. This is super confusing, see python/cpython#73996. Anyway, in 3.10 making this mistake isn't possible anymore due python/cpython#26646. To make sure this does not break in the future, we also add tests for the IP and client certs cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue44362