Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about Netlify preview for docs on GitHub PRs #526

Closed
willingc opened this issue Aug 21, 2019 · 5 comments
Closed

Add information about Netlify preview for docs on GitHub PRs #526

willingc opened this issue Aug 21, 2019 · 5 comments

Comments

@willingc
Copy link
Collaborator

See python/cpython#15288

@aeros
Copy link
Contributor

aeros commented Aug 22, 2019

@willingc This would probably be bested suited for https://devguide.python.org/documenting/ (documenting.rst). Since this section would be fairly small, straight forward, and is already well defined do you think it would be a decent candidate for good first issue?

I wouldn't mind helping with this, but I think it would serve well as a decent introductory issue for contributing to documentation. I'll add the label for now, feel free to remove it though.

@aeros aeros added good first issue New contributors github labels Aug 22, 2019
@adam-does-code
Copy link

Hey! Can I take this issue on? :-)

@aeros
Copy link
Contributor

aeros commented Oct 9, 2019

@De-Ma Sure! Feel free to work on this, but keep it mind that we may have to wait for the Netlify setup to be completely finished before we can merge the section into the devguide. See python/cpython#15288 (comment).

From my understanding, someone with access to the Python organization account such as @ewdurbin or @benjaminp has to install the Netlify GitHub App to the organization account and then choose what repositories to authorize it for. This explained in https://www.netlify.com/docs/github-permissions. I know it's at least needed for CPython, but it might useful for others as well.

Edit: It looks like they also have to create a Netlify account for the Python org, since the devguide one is using @Mariatta's personal account.

@sparkingdark
Copy link

@willingc is this still open or the work is done

@Mariatta
Copy link
Member

This is outdated. We are no using readthedocs's PR build preview instead of netlify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants