Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The page becomes wider than the viewport on certain PEPs #2476

Closed
pradyunsg opened this issue Mar 28, 2022 · 2 comments · Fixed by #2478
Closed

The page becomes wider than the viewport on certain PEPs #2476

pradyunsg opened this issue Mar 28, 2022 · 2 comments · Fixed by #2478
Assignees
Labels
bug infra Core infrastructure for building and rendering PEPs

Comments

@pradyunsg
Copy link
Member

See https://peps.python.org/pep-0440/

The PEP is presented wider than other PEPs are presented, which makes the contents of this PEP more difficult to read.

@pradyunsg
Copy link
Member Author

pradyunsg commented Mar 28, 2022

Screenshot 2022-03-28 at 19 09 47

Screenshot 2022-03-28 at 19 09 35

Screenshots of the viewport for comparisions. On Firefox 98.0.1, MacOS.

@CAM-Gerlach CAM-Gerlach changed the title The page becomes wider than the viewport, on certain PEPs The page becomes wider than the viewport on certain PEPs Mar 28, 2022
@CAM-Gerlach CAM-Gerlach self-assigned this Mar 28, 2022
@CAM-Gerlach CAM-Gerlach added bug infra Core infrastructure for building and rendering PEPs labels Mar 28, 2022
@CAM-Gerlach
Copy link
Member

Thanks for reporting! The problem is due to the literal block in this section that has an extremely long <span>s (i.e. the regex that has no breaks and is syntax-highlighted text with the same color).

To make a long story short, after some investigation and testing, setting an appropriately-bounded max-width on the page content for the widest breakpoint (where it was previously unbounded) avoided this problem and ensured the page displayed identically to other PEPs with more typical content, while not affecting anything else.

I opened PR #2478 with the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants