Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 585: clarify removal as "no sooner than" #2778

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Aug 30, 2022

See https://discuss.python.org/t/concern-about-pep-585-removals

I mentioned the date explicitly so people not familiar with Python
release schedule have less arithmetic to do.

I also change the phrasing of the date to Python 3.9's EOL. The date
remains the same. Again, this is to help ease fear of writing 3.8 bridging
code for people who don't know Python version lifespan.
This should also be in line with ambv's (original author) intentions;
see bolded part of his message at
https://discuss.python.org/t/concern-about-pep-585-removals/15901/14

See https://discuss.python.org/t/concern-about-pep-585-removals

I mentioned the date explicitly so people not familiar with Python
release schedule have less arithmetic to do.

I also change the phrasing of the date to Python 3.9's EOL. The date
remains the same. This is important because it clarifies that you don't
have to write bridging code. This should also be in line with ambv's
(original author) intentions; see bolded part of his message at
https://discuss.python.org/t/concern-about-pep-585-removals/15901/14
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really want it to say "will be removed" at all as I don't really want to ever remove it. Can we say "may eventually be removed" instead?

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@hugovk
Copy link
Member

hugovk commented Sep 12, 2022

@JelleZijlstra How's it sound now, good to merge?

The deprecated functionality may eventually be removed from the typing
module. Removal will occur no sooner than Python 3.9's end of life,
scheduled for October 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants