Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enum] officially support member.member access and remove deprecation #182

Closed
ethanfurman opened this issue Apr 5, 2023 · 2 comments
Closed

[Enum] officially support member.member access and remove deprecation #182

ethanfurman opened this issue Apr 5, 2023 · 2 comments

Comments

@ethanfurman
Copy link
Member

Due to performance concerns, and seeing some good examples of when member.member access makes sense, I'd like to remove the deprecation and instead officially support it.

Does anything special need to happen to approve this, or do I just update the docs, code, etc.? The current PR is here.
@gpshead
Copy link
Member

gpshead commented Apr 5, 2023

additional context: this means closing python/cpython#95077 as "not planned".

@gpshead
Copy link
Member

gpshead commented Apr 5, 2023

A few of us chatted: agreed, keep the member.member behavior instead of the deprecation.

Focusing on some mix of existing exposed enum API compatibility and enabling better performance seems like a great idea.

@gpshead gpshead closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpshead @ethanfurman