Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

pgen instructions in readme #15

Closed
fyquah opened this issue Sep 9, 2016 · 2 comments
Closed

pgen instructions in readme #15

fyquah opened this issue Sep 9, 2016 · 2 comments

Comments

@fyquah
Copy link

fyquah commented Sep 9, 2016

I followed the instructions to get a working pgen binary and ran into the following compilation error:

Parser/grammar1.c: In function ‘PyGrammar_LabelRepr’:
Parser/grammar1.c:50:20: error: ‘_PyParser_TokenNames’ undeclared (first use in this function)
             return _PyParser_TokenNames[lb->lb_type];
                    ^
Parser/grammar1.c:50:20: note: each undeclared identifier is reported only once for each function it appears in
Parser/grammar1.c:61:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

It is mentioned in the README that we need to overwrite Include/token.h, Include/compile.h, and Parser/tokenizer.c, I assume that's referring to replacing those in cpython with those in typed_ast/ast35 right?

@ddfisher
Copy link
Collaborator

Yes, that's correct. I think you may also need to unmangle the function names from Ta35* to Py*. It's pretty unfortunate -- I'm hoping to find a better way to get a working pgen at some point.

@ddfisher
Copy link
Collaborator

ddfisher commented Feb 13, 2017

The files for pgen are now included, and pgen is compiled as part of ./tools/update_ast3_grammar

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants