Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for "preparing the environment" fail on Windows #6282

Closed
AlexWaygood opened this issue Nov 12, 2021 · 1 comment · Fixed by #6284
Closed

Instructions for "preparing the environment" fail on Windows #6282

AlexWaygood opened this issue Nov 12, 2021 · 1 comment · Fixed by #6284
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@AlexWaygood
Copy link
Member

I'm on a Windows machine. Inside my typeshed clone and a fresh virtual environment, if I run python -m pip install -r requirements-tests-py3.txt, it fails due to the fact that pytype is not currently supported on Windows.

pytype also doesn't currently support Python 3.10.

The instructions in CONTRIBUTING.md don't state that MacOS/Linux is a necessary requirement to run the tests locally (and, it might be nice to have a narrower suite of tests that can be easily run on Windows! 🙂). CONTRIBUTING.md should also probably be updated to state that running tests on Python 3.10 is not yet supported.

@AlexWaygood AlexWaygood changed the title Instructions for running tests fails on Windows Instructions for "preparing the environment" fail on Windows Nov 12, 2021
@srittau srittau added the project: infrastructure typeshed build, test, documentation, or distribution related label Nov 12, 2021
@srittau
Copy link
Collaborator

srittau commented Nov 12, 2021

All sound like good points. PRs welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants