Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party tests failed on Tue Nov 12 2024 #503

Closed
github-actions bot opened this issue Nov 12, 2024 · 5 comments · Fixed by #504
Closed

Third-party tests failed on Tue Nov 12 2024 #503

github-actions bot opened this issue Nov 12, 2024 · 5 comments · Fixed by #504

Comments

@github-actions
Copy link

Full history of runs listed here: https://github.com/python/typing_extensions/actions/workflows/third_party.yml

@brianschubert
Copy link
Contributor

pydantic tests are failing again:

  uv sync --group testing --group dev
  shell: /usr/bin/bash -e {0}
  env:
    PIP_DISABLE_PIP_VERSION_CHECK: 1
    FORCE_COLOR: 1
    UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
error: Group `testing` is not defined in the project's `dependency-group` table
Error: Process completed with exit code 2.

Looks like this is due to pydantic/pydantic#10815, which changed the dependency group definitions.

@Viicos
Copy link
Contributor

Viicos commented Nov 12, 2024

Sorry again for the inconvenience, I'll fix this one.

@Viicos
Copy link
Contributor

Viicos commented Nov 12, 2024

Alternatively, maybe it's best to remove the pydantic third-party test, as we already test on typing-extensions main on our end?

@AlexWaygood
Copy link
Member

I think it's pretty useful for us to have an immediate notification when we've broken pydantic. "We will break pydantic by cutting a release" is definitely bad enough to block a release for us, IMO -- the last time I did that it wasn't so fun 😆

We knew there was a risk of this workflow occasionally breaking due to things like this when we added the workflow. Unless you expect these breakages to be very common, rather than just a few teething issues while you migrate to uv, I think I'd probably vote to stick with things as they are. typing_extensions is important enough in the ecosystem that a little bit more maintenance burden for us is OK if it avoids us breaking the world, I think.

I guess I'd also be okay with a workflow where you immediately open an issue with us if your nightly tests with the typing_extensions main branch fail! I just really really don't want us cutting a release that breaks you guys without us being aware of it first. Even if it's a problem at your end, we'd almost certainly want to wait until you guys fixed it before we cut a new release 😄

@Viicos
Copy link
Contributor

Viicos commented Nov 12, 2024

Sounds good, in that case, we'll try to avoid changing too many things in our CI. If you ever get new pydantic failures, do not hesitate to assign/ping me and I'll be available to provide a fix if possible. I'm currently working on tidying out our CI, and will update the third party test here accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants