-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third-party tests failed on Tue Nov 12 2024 #503
Comments
pydantic tests are failing again:
Looks like this is due to pydantic/pydantic#10815, which changed the dependency group definitions. |
Sorry again for the inconvenience, I'll fix this one. |
Alternatively, maybe it's best to remove the pydantic third-party test, as we already test on typing-extensions |
I think it's pretty useful for us to have an immediate notification when we've broken pydantic. "We will break pydantic by cutting a release" is definitely bad enough to block a release for us, IMO -- the last time I did that it wasn't so fun 😆 We knew there was a risk of this workflow occasionally breaking due to things like this when we added the workflow. Unless you expect these breakages to be very common, rather than just a few teething issues while you migrate to uv, I think I'd probably vote to stick with things as they are. I guess I'd also be okay with a workflow where you immediately open an issue with us if your nightly tests with the |
Sounds good, in that case, we'll try to avoid changing too many things in our CI. If you ever get new pydantic failures, do not hesitate to assign/ping me and I'll be available to provide a fix if possible. I'm currently working on tidying out our CI, and will update the third party test here accordingly. |
Full history of runs listed here: https://github.com/python/typing_extensions/actions/workflows/third_party.yml
The text was updated successfully, but these errors were encountered: