Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Commit

Permalink
Update base for Update on "rename all variables to use input/weight/g…
Browse files Browse the repository at this point in the history
…rad_output notation"

Summary:

In #323 we
changed the user facing variable notation from `x/w/dL_dY` to
`input/weight/grad_output`.

This PR follows up by changing most of the internal variables to also match
the new notation, to reduce confusion.

Test Plan:

```
./test/test_everything.sh
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
  • Loading branch information
vkuzo committed Jul 25, 2024
1 parent 994057c commit e04e687
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion float8_experimental/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class Float8LinearConfig:
#
gemm_config_output: Float8GemmConfig = Float8GemmConfig(use_fast_accum=True)
gemm_config_grad_input: Float8GemmConfig = Float8GemmConfig()
gemm_config_grad_weight: Float8GemmConfig = Float8GemmConfig(use_fast_accum=True)
gemm_config_grad_weight: Float8GemmConfig = Float8GemmConfig()

#
# Per-linear configuration
Expand Down

0 comments on commit e04e687

Please sign in to comment.