From ea822945d345adc4847bd56bf03b0cb07667e0d3 Mon Sep 17 00:00:00 2001 From: tal66 <77445020+tal66@users.noreply.github.com> Date: Tue, 17 May 2022 09:47:18 -0700 Subject: [PATCH] Make requirements.txt single source of truth (#414) Summary: Hi, this fixes https://github.com/pytorch/data/issues/410. Pull Request resolved: https://github.com/pytorch/data/pull/414 Reviewed By: ejguan Differential Revision: D36445769 Pulled By: NivekT fbshipit-source-id: 929a0d3160f62c5da64c429012862710447e5220 --- setup.py | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/setup.py b/setup.py index 540fbdbf8..f5c44dfad 100644 --- a/setup.py +++ b/setup.py @@ -98,6 +98,17 @@ def _export_version(version, sha): f.write(f"git_version = {repr(sha)}\n") +def _get_requirements(): + req_list = [] + with Path("requirements.txt").open("r") as f: + for line in f: + req = line.strip() + if len(req) == 0 or req.startswith("#"): + continue + req_list.append(req) + return req_list + + # Use new version of torch on main branch pytorch_package_dep = "torch>1.11.0" if os.getenv("PYTORCH_VERSION"): @@ -105,11 +116,8 @@ def _export_version(version, sha): pytorch_package_dep += "==" + os.getenv("PYTORCH_VERSION") -requirements = [ - "urllib3 >= 1.25", - "requests", - pytorch_package_dep, -] +requirements = _get_requirements() +requirements.append(pytorch_package_dep) class clean(distutils.command.clean.clean):