Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate transforms.RandomSizedCrop in torchvision example #311

Closed
wants to merge 1 commit into from
Closed

Deprecate transforms.RandomSizedCrop in torchvision example #311

wants to merge 1 commit into from

Conversation

xiaohu2015
Copy link
Contributor

Fixes #{issue number}

Changes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan changed the title fix typo in transforms.RandomResizedCrop Deprecate transforms.RandomSizedCrop in torchvision example Mar 21, 2022
ejguan
ejguan approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

@ejguan
Copy link
Contributor

ejguan commented Mar 21, 2022

@NivekT Just want to confirm the mypy Error is caused by the change in PyTorch Core and not related to the PR.

@NivekT
Copy link
Contributor

NivekT commented Mar 21, 2022

@NivekT Just want to confirm the mypy Error is caused by the change in PyTorch Core and not related to the PR.

Yes, that is correct. It should go away when my stack of PRs land.

@xiaohu2015 xiaohu2015 deleted the patch-1 branch March 22, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT approved these changes

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaohu2015 @facebook-github-bot @ejguan @NivekT