Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input_col to flatmap #363

Closed
wants to merge 1 commit into from
Closed

Add input_col to flatmap #363

wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Apr 18, 2022

This change is required to align DataPipe and DataFrame API

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan requested a review from NivekT April 18, 2022 18:52
wenleix
wenleix approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NivekT
NivekT approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think map has output_col, is the plan to generally only add input_col to align with other APIs?

@ejguan
Copy link
Contributor Author

ejguan commented Apr 19, 2022

LGTM! I think map has output_col, is the plan to generally only add input_col to align with other APIs?

flatmap is not going to support output_col unless we receive more feature request because adding a output_col needs broadcasting the columns from the original input and it's not safe to do the broadcasting when DataPipe takes arbitrary python objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenleix wenleix wenleix approved these changes

@NivekT NivekT NivekT approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejguan @facebook-github-bot @wenleix @NivekT