Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating contributing guide, small fixes, and adding guidance for MapDataPipe #379

Closed
wants to merge 3 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Apr 28, 2022

Stack from ghstack:

The changes here do not impact any functionalities. Let me know if anything is unclear and I will make additional edits.

Differential Revision: D36014738

NivekT added a commit that referenced this pull request Apr 28, 2022
…DataPipe

ghstack-source-id: 5933b2b39171974a93ff1c13bfa9b2286a6f78f2
Pull Request resolved: #379
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2022
@NivekT NivekT requested a review from ejguan April 28, 2022 18:29
@NivekT
Copy link
Contributor Author

NivekT commented Apr 28, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Have a few nit comments

…nce for MapDataPipe"


The changes here do not impact any functionalities. Let me know if anything is unclear and I will make additional edits.

Differential Revision: [D36014738](https://our.internmc.facebook.com/intern/diff/D36014738)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Apr 28, 2022
…DataPipe

ghstack-source-id: e75c31d9b049aa200f726085de2612acd73493c2
Pull Request resolved: #379
@NivekT
Copy link
Contributor Author

NivekT commented Apr 28, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…nce for MapDataPipe"


The changes here do not impact any functionalities. Let me know if anything is unclear and I will make additional edits.

Differential Revision: [D36014738](https://our.internmc.facebook.com/intern/diff/D36014738)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Apr 28, 2022
…DataPipe

ghstack-source-id: c508d866ba1211ea4d3b3610f82e8261b1139d0d
Pull Request resolved: #379
@NivekT
Copy link
Contributor Author

NivekT commented Apr 28, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/74/head branch May 2, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants